[BlueOnyx:24150] Shellinabox doesn't work for site users

[Tomohiro Hosaka]

Hello.

On 5209R, when I access "Programs/Console Login", I am redirected to
/gui/Forbidden403.

If you are an admin, jump to /remote/console?group=siteX and it will
work properly.

If you are a site user, jump to /gui/Forbidden403 and it won't work.

The bottom has been checked.
- "Shellinabox" must be enabled under "Network Services" / "Shell".
- User must be able to login to the GUI
- User must have shell access enabled
- User accesses "Programs" / "Console Login" from within the GUI.

When fixed as below, it seems to work as expected, is it a bug?

# diff -u /usr/sausalito/ui/chorizo/ci/application/modules/base/remote/controllers/console.php-00
/usr/sausalito/ui/chorizo/ci/application/modules/base/remote/controllers/console.php
--- /usr/sausalito/ui/chorizo/ci/application/modules/base/remote/controllers/console.php-00
    2020-05-28 05:04:04.000000000 +0900
+++ /usr/sausalito/ui/chorizo/ci/application/modules/base/remote/controllers/console.php
       2020-08-06 12:44:03.290872570 +0900
@@ -42,7 +42,7 @@
         $Capabilities = new Capabilities($CI->cceClient,
$CI->BX_SESSION['loginName'], $CI->BX_SESSION['sessionId']);

         // No Shell access? Bye, bye!
-        if ((!$Capabilities->getAllowed('serverShell')) ||
(!$Capabilities->getAllowed('siteShell')) ||
(!$Capabilities->getAllowed('resellerShell'))) {
+        if (!($Capabilities->getAllowed('serverShell') ||
$Capabilities->getAllowed('siteShell') ||
$Capabilities->getAllowed('resellerShell'))) {
             // Nice people say goodbye, or CCEd waits forever:
             $CI->cceClient->bye();
             $CI->serverScriptHelper->destructor();
@@ -242,4 +242,4 @@
 nuclear facility.

 */


Thanks,