[BlueOnyx:15165] Re: YUM updates for 5106R/5107R/5108R

[Michael Stauber]

Hi Hisao,

> I checked with the latest updates and looked your codes.
> I’m agree with your update on this version, you add the translation code for
> some field which is allowed to enter Japanese.
> I think that to call multibyte function affect some performance.

Yes, it's certainly slower than it could be.

> I found some corruption with specific character like the following.
> http://www.alpha.or.jp/~shibuya/BlueOnyx/UserList-currupt.png
> 
> I tested with some character and strings pattern that it is sometimes corrupt,
> sorry I worked QA team for Japanese Qube3 and RaQ550 ;-p

Which is really good and I appreciate that you took a look at it. Q&A
never hurts.

> Some strings aren't detected with right encoding. Generally, mb_detect_encoding
> detected with wrong encoding with short strings or encoding order.
> So, can you change the encoding order for detection, if there is no problem with
> other language like as non-ASCII with umlauts.
> 
> -----
> --- I18n.php.orig       2014-04-10 09:01:24.000000000 +0900
> +++ I18n.php    2014-04-10 09:31:47.000000000 +0900
> @@ -83,7 +83,7 @@
>    }
>  
>    function Utf8Encode($text) {
> -      if (mb_detect_encoding($text, "JIS, EUC-JP, ISO-8859-1, ISO-8859-15, windows-1252, UTF-8") == "EUC-JP") {
> +      if (mb_detect_encoding($text, "JIS, UTF-8, EUC-JP, ISO-8859-1, ISO-8859-15, windows-1252") == "EUC-JP") {
>          $text = mb_convert_encoding($text, "UTF-8", "EUC-JP");
>        }
>        if (I18n::detectUTF8($text) == "1" ) {
> ——

Yes, I think that should work a lot better. I'll submit it to SVN and
will release it today. Together with the fix for the sortOrder field on
the userAdd page.

Many thanks!

-- 
With best regards

Michael Stauber